fix: add explicit timeout to OpenAPI tool httpx client by fuki01 · Pull Request #4432 · google/adk-python

fuki01 · 2026-02-10T12:53:24Z

Summary

PR Make OpenAPI tool async #2872 migrated OpenAPI tools from requests to httpx.AsyncClient, but did not specify a timeout
requests defaults to no timeout, while httpx defaults to 5 seconds
This causes httpx.ReadTimeout for API calls taking longer than 5 seconds

This PR sets timeout=None to restore the previous requests behavior as a minimal fix.

Note: None (no timeout) matches the previous behavior, but the team may want to choose a more appropriate default value in a follow-up.

Closes #4431

google-cla · 2026-02-10T12:53:36Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist · 2026-02-10T12:53:38Z

Summary of Changes

Hello @fuki01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where OpenAPI tool HTTP requests were failing due to an unexpected timeout. The underlying HTTP client library, httpx, introduced a default 5-second timeout after a recent migration, which was not present in the previously used requests library. The change ensures that API calls are no longer prematurely terminated by setting the timeout to None, effectively reverting to the prior behavior of allowing requests to complete without an explicit timeout limit.

Highlights

Timeout Discrepancy: Identified that the migration from requests to httpx.AsyncClient in PR Make OpenAPI tool async #2872 introduced a default 5-second timeout in httpx, unlike requests which defaults to no timeout.
ReadTimeout Errors: This change caused httpx.ReadTimeout errors for API calls that exceeded the new 5-second default timeout.
Timeout Restoration: Implemented a fix by explicitly setting timeout=None for httpx.AsyncClient, thereby restoring the original behavior of no timeout, consistent with the previous requests implementation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py
- Set timeout=None for httpx.AsyncClient to prevent ReadTimeout errors and restore previous behavior.

Activity

Pull request created by fuki01.
Issue fix: OpenAPI tool _request missing timeout causes ReadTimeout with default httpx 5s #4431, concerning httpx.ReadTimeout errors, was closed by this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

adk-bot · 2026-02-10T12:54:33Z

Response from ADK Triaging Agent

Hello @fuki01, thank you for creating this PR!

Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

In addition, could you please provide a testing plan and logs or screenshot after the fix is applied?

This information will help reviewers to review your PR more efficiently. Thanks!

gemini-code-assist

Code Review

This pull request addresses a httpx.ReadTimeout issue by setting an explicit timeout=None for the httpx.AsyncClient, restoring the previous behavior of the requests library. While this fixes the immediate problem, I have a significant concern about disabling timeouts altogether, as it can lead to service instability. I've added a high-severity comment recommending the use of a large default timeout as a safety measure instead of completely disabling it.

gemini-code-assist · 2026-02-10T12:54:42Z

src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py

  async with httpx.AsyncClient(
-      verify=request_params.pop("verify", True)
+      verify=request_params.pop("verify", True),
+      timeout=None,


While setting timeout=None restores the previous behavior of requests and fixes the immediate httpx.ReadTimeout issue, it introduces a significant risk. Disabling timeouts can cause requests to hang indefinitely if the remote API is unresponsive, potentially leading to resource exhaustion and service instability.

Even though a follow-up is mentioned in the pull request description, I strongly recommend addressing this now by setting a generous default timeout (e.g., 10 minutes) instead of None. This would provide a crucial safety net. A truly indefinite timeout should be an explicit choice by the user of the tool, not the default behavior.

The migration from `requests` to `httpx.AsyncClient` in PR google#2872 did not specify a timeout parameter. Since `requests` defaults to no timeout while `httpx` defaults to 5 seconds, this causes `ReadTimeout` errors for API calls that take longer than 5 seconds. Set timeout to `None` to restore the previous behavior. Closes google#4431

ryanaiagent · 2026-02-11T18:56:35Z

/gemini review

gemini-code-assist

Code Review

This pull request addresses an httpx.ReadTimeout issue by setting an explicit timeout for the httpx.AsyncClient. The change restores the previous behavior of the requests library, which had no timeout by default. My review includes a suggestion to make the timeout handling more robust and configurable. While the current fix works, disabling timeouts completely can be risky. The suggestion aims to improve the design for future enhancements without changing the immediate behavior of this fix.

gemini-code-assist · 2026-02-11T18:57:40Z

src/google/adk/tools/openapi_tool/openapi_spec_parser/rest_api_tool.py

  async with httpx.AsyncClient(
-      verify=request_params.pop("verify", True)
+      verify=request_params.pop("verify", True),
+      timeout=None,


While setting timeout=None restores the previous behavior of requests, it's risky to have no timeout as requests can hang indefinitely, potentially leading to resource exhaustion.

To make this more robust and prepare for a future change where the timeout is configurable (as mentioned in the PR description), I suggest reading the timeout from request_params. This way, RestApiTool can be updated to control the timeout value without needing to change this helper function again.

Using request_params.pop("timeout", None) will keep the current behavior of no timeout by default if no other changes are made, but makes the function extensible for a proper fix.

Suggested change

timeout=None,

timeout=request_params.pop("timeout", None),

can you please address this.

I've updated the implementation based on the feedback:

Changed to request_params.pop("timeout", httpx.Timeout(600.0)) — this makes the timeout configurable via request_params, so RestApiTool can control timeout without modifying _request() in the future.

Instead of None (no timeout), I set a generous 10-minute default as a safety net to prevent indefinite hangs while still accommodating slow API responses.

ryanaiagent · 2026-02-11T19:23:38Z

Hi @fuki01, Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please address the suggestion.

Use request_params.pop("timeout", None) instead of hardcoded None, allowing RestApiTool to control timeout without modifying _request().

Set a generous 600s default to prevent indefinite hangs while still accommodating slow API responses.

adk-bot added the tools [Component] This issue is related to tools label Feb 10, 2026

gemini-code-assist bot reviewed Feb 10, 2026

View reviewed changes

fuki01 force-pushed the fix/openapi-tool-timeout branch from 415aa5a to 69d0179 Compare February 11, 2026 07:57

ryanaiagent self-assigned this Feb 11, 2026

gemini-code-assist bot reviewed Feb 11, 2026

View reviewed changes

ryanaiagent added the request clarification [Status] The maintainer need clarification or more information from the author label Feb 11, 2026

fuki01 added 2 commits February 12, 2026 08:12

fix: make timeout configurable via request_params

d6546d8

Use request_params.pop("timeout", None) instead of hardcoded None, allowing RestApiTool to control timeout without modifying _request().

fix: use 10-minute default timeout instead of None

d12bdc2

Set a generous 600s default to prevent indefinite hangs while still accommodating slow API responses.

fuki01 force-pushed the fix/openapi-tool-timeout branch from fad2e4e to d12bdc2 Compare February 11, 2026 23:12

fuki01 requested a review from ryanaiagent February 11, 2026 23:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add explicit timeout to OpenAPI tool httpx client#4432

fix: add explicit timeout to OpenAPI tool httpx client#4432
fuki01 wants to merge 3 commits intogoogle:mainfrom
fuki01:fix/openapi-tool-timeout

fuki01 commented Feb 10, 2026

Uh oh!

google-cla bot commented Feb 10, 2026

Uh oh!

gemini-code-assist bot commented Feb 10, 2026

Uh oh!

adk-bot commented Feb 10, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 10, 2026

Uh oh!

ryanaiagent commented Feb 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 11, 2026

Uh oh!

ryanaiagent Feb 11, 2026

Uh oh!

fuki01 Feb 11, 2026

Uh oh!

ryanaiagent commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fuki01 commented Feb 10, 2026

Summary

Uh oh!

google-cla bot commented Feb 10, 2026

Uh oh!

gemini-code-assist bot commented Feb 10, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

adk-bot commented Feb 10, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

ryanaiagent commented Feb 11, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

ryanaiagent Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

fuki01 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

ryanaiagent commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants